[TRTLLM-13948][test] Add DeepSeek R1/V3.2/V3-Lite disaggregated accur…#16344
[TRTLLM-13948][test] Add DeepSeek R1/V3.2/V3-Lite disaggregated accur…#16344asfiyab-nvidia wants to merge 5 commits into
Conversation
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #59041 [ run ] triggered by Bot. Commit: |
|
PR_Github #59041 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #59251 [ run ] triggered by Bot. Commit: |
|
PR_Github #59251 [ run ] completed with state
|
|
The failing tests listed below are unrelated to the transceiver changes made in this PR |
📝 WalkthroughWalkthroughUpdated disaggregated serving integration tests for NIXL Python KV-cache manager v1, added DeepSeekR1 coverage, adjusted DeepSeekV32Exp configuration, and registered both tests in QA and DGX B300 test lists. ChangesDisaggregated KV-cache coverage
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant AccuracyTest
participant launch_disaggregated_llm
participant ContextServer
participant GenerationServer
participant NIXLPython
AccuracyTest->>launch_disaggregated_llm: launch cache-manager v1 configuration
launch_disaggregated_llm->>ContextServer: start context server
launch_disaggregated_llm->>GenerationServer: start generation server
ContextServer->>NIXLPython: write KV cache
NIXLPython->>GenerationServer: provide KV cache
GenerationServer-->>AccuracyTest: return generation result
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/qa/llm_function_core.txt (1)
1-1: 📐 Maintainability & Code Quality | 🔵 TrivialCoverage currently limited to
cache_mgr_v1only for both new entries.Both new QA entries (
TestDeepSeekR1andTestDeepSeekV32Exptest_kv_cache_v2_nixl_python[cache_mgr_v1]) only exercise the KV-cache-manager-v1 path, per the parametrize decorators added intest_disaggregated_serving.py. This matches the PR's intentional narrowing (per commit history) after CI issues with the v2 path, but flagging for follow-up: once thecache_mgr_v2path stabilizes, this list (andl0_dgx_b300.yml) should be updated to add the[cache_mgr_v2]variant, consistent with howTestGemma3_1BInstruct/TestGPTOSSregister bothcache_mgr_v1andcache_mgr_v2ids here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/qa/llm_function_core.txt` at line 1, Update the QA registrations for TestDeepSeekR1 and TestDeepSeekV32Exp to include the test_kv_cache_v2_nixl_python[cache_mgr_v2] variant once the cache_mgr_v2 path is stable, matching the existing cache_mgr_v1 entries and the dual registrations used by TestGemma3_1BInstruct and TestGPTOSS; also add the corresponding variant to l0_dgx_b300.yml.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/defs/accuracy/test_disaggregated_serving.py`:
- Around line 2809-2869: Set enable_autotuner to False in both ctx_server_config
and gen_server_config within TestDeepSeekR1.test_kv_cache_v2_nixl_python.
Preserve all other server settings and ensure both context and generation
servers skip autotuner warmup.
---
Nitpick comments:
In `@tests/integration/test_lists/qa/llm_function_core.txt`:
- Line 1: Update the QA registrations for TestDeepSeekR1 and TestDeepSeekV32Exp
to include the test_kv_cache_v2_nixl_python[cache_mgr_v2] variant once the
cache_mgr_v2 path is stable, matching the existing cache_mgr_v1 entries and the
dual registrations used by TestGemma3_1BInstruct and TestGPTOSS; also add the
corresponding variant to l0_dgx_b300.yml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 47c62172-cd90-48d0-8774-b8a2019896ad
📒 Files selected for processing (3)
tests/integration/defs/accuracy/test_disaggregated_serving.pytests/integration/test_lists/qa/llm_function_core.txttests/integration/test_lists/test-db/l0_dgx_b300.yml
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #59320 [ run ] triggered by Bot. Commit: |
|
PR_Github #59320 [ run ] completed with state
|
|
/bot run |
|
PR_Github #59491 [ run ] triggered by Bot. Commit: |
|
PR_Github #59491 [ run ] completed with state |
|
PR_Github #60436 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60441 [ run ] triggered by Bot. Commit: |
|
PR_Github #60441 [ run ] completed with state
|
a56f77b to
c34b46c
Compare
|
/bot run --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60449 [ run ] triggered by Bot. Commit: |
|
PR_Github #60449 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60490 [ run ] triggered by Bot. Commit: |
|
PR_Github #60490 [ run ] completed with state
|
…acy tests Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
c34b46c to
16ae92b
Compare
|
/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60617 [ run ] triggered by Bot. Commit: |
|
PR_Github #60617 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60673 [ run ] triggered by Bot. Commit: |
|
PR_Github #60673 [ run ] completed with state
|
|
/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60706 [ run ] triggered by Bot. Commit: |
|
/bot run --stage-list "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2" |
|
PR_Github #60711 [ run ] triggered by Bot. Commit: |
|
PR_Github #60706 [ run ] completed with state |
|
PR_Github #60711 [ run ] completed with state
|
This pull request adds new integration tests for the DeepSeekR1 and DeepSeekV3.2 models to validate the behavior of KV cache manager v1 using the NIXL Python transceiver in a disaggregated serving setup.
New test coverage:
Added test_kv_cache_v2_nixl_python in TestDeepSeekR1 and TestDeepSeekV32Exp to test DeepSeekR1 and DeepSeekV3.2 with NIXL Python transceiver and KV cache manager v1, including configuration for context and generation servers with tensor parallelism and cache settings.
Test suite and test database updates:
Registered the new parameterized tests for cache manager v1 in the QA test list (test_lists/qa/llm_function_core.txt).
Added the new tests to the l0_dgx_b300 test database for automated runs on the appropriate hardware.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Tests